Arcana Auth SDK support #1744
Arcana Auth SDK support #1744
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
So, how is the documentation package supposed to install a unpublished package? Should I split this into two PRs, so that the package can be published first? |
|
@mmjee Overall- looking good. |
mmjee
force-pushed
the
feature/arcana-auth
branch
from
9e17acc
to
8ff5d62
Compare
I tried to reproduce the above issue but I couldn't actually get it to switch to Görli because of Infura (and the API key is hardcoded).
|
|
you can update the goerli rpc url in packages/demo/src/App.svelte I'll make a note to update that in our demo |
|
@leightkt Updated the RPC URL, it should work assuming you have Görli ETH in the address. |
|
@mmjee I still get the same 'UNSUPPORTED_OPERATION' error shown in my testing video above (able to switch to goerli, have test ETH in my account) |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
@mmjee moving this to draft until the 'UNSUPPORTED_OPERATION' error when sending a transaction can be address. Thx! |
|
On 6/27/23 22:34, Kat Leight wrote:
@mmjee moving this to draft until the 'UNSUPPORTED_OPERATION' error when sending a transaction can be address. Thx!
Yes, it looks like we are mishandling EIP-1559 transactions so this is blocked until we figure out what the problem is and fix it.
--
Regards,
|
|
@leightkt Can you confirm whether the issue above still occurs? |
|
@mmjee I can no longer connect to the wallet |
mmjee
force-pushed
the
feature/arcana-auth
branch
from
0998469
to
a736a1a
Compare
Updated the packages, should be working now. Works locally. |
|
|
On ২৬/৭/২৩ ২১:৫০, Kat Leight wrote:
<img width="1344" alt="Screenshot 2023-07-26 at 10 17 12 AM" src="https://github.com/blocknative/web3-onboard/assets/33187102/8f9fc31b-5430-4616-aaf5-bdf7bf82cb39">
Do you see anything in the DevTools Network Tab? This is a web wallet so
everything should be loaded in dynamically. Does that work on a browser
w/o extensions?
I can confirm it works locally.
--
Regards,
|
|
@mmjee I was able to login only on a browser where I can no other extensions installed. Please make a note in the arcana README that this is expected behavior Once logged in, I can switch chains, sign a message, sign a typed message, and disconnect the wallet. I cannot send a Transaction on Goerli:
|
|
On 7/28/23 03:13, Kat Leight wrote:
@mmjee I was able to login only on a browser where I can no other extensions installed. Please make a note in the arcana README
Arcana Auth is supposed to work with all popular browsers and works even when 3rd party cookies are blocked. It should work by default for most browsers even with extensions. If you can, please narrow it down to an extension and/or configuration that could be causing it.
Once logged in, I can switch chains, sign a message, sign a typed message, and disconnect the wallet.
I cannot send a Transaction on Goerli:
Can you please retry again? We have added a few more fixes to EIP-1559 transaction handling.
--
Regards,
|
|
@mmjee success! Please add a note to the the Arcana readme and docs page that users may need to disable other wallet extensions in order to connect to Arcana. Also- the Arcana docs page needs to be moved to [..1]arcana to respect alpha order. I can push that change (and handle the renaming of the other docs pages to keep the order) if you want to give me write access. Once those two things are completed it's good to go! |
Got it, fixing docs and readme as suggested above. cc: @mmjee @leightkt |
mmjee
force-pushed
the
feature/arcana-auth
branch
from
c789e7e
to
91401c6
Compare
|
@leightkt All changes are ready to be reviewed. |
|
@mmjee getting an error on our circleci build- please put up a new PR to fix. 
|
* Arcana Auth SDK support (#1744) * Fix: Aracana Config (#1857) * add steps * build staging steps * update arcana package and yarn (#1858) * update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <[email protected]> * Update Arcana Auth SDK version (#1860) * update arcana/demo packages and root version * add ts-ignore for arcana * Feat: Add native Base chain support and to all quickstarts (#1859) * Add Base chain to all quickstarts * Bump core package in demo * update core, react, vue versions --------- Co-authored-by: Adam Carpenter <[email protected]> Co-authored-by: mmjee <[email protected]>
* Arcana Auth SDK support (#1744) * Fix: Aracana Config (#1857) * add steps * build staging steps * update arcana package and yarn (#1858) * update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <[email protected]> * Update Arcana Auth SDK version (#1860) * update arcana/demo packages and root version * add ts-ignore for arcana * Feat: Add native Base chain support and to all quickstarts (#1859) * Add Base chain to all quickstarts * Bump core package in demo * update core, react, vue versions --------- Co-authored-by: Adam Carpenter <[email protected]> Co-authored-by: mmjee <[email protected]>
* Arcana Auth SDK support (#1744) * Fix: Aracana Config (#1857) * add steps * build staging steps * update arcana package and yarn (#1858) * update arcana package and yarn * fix spacing in config * try update spacing * reset spacing on config * update ci branch for test * add ts-ignore * reset config to develop * add file extension to icon --------- Co-authored-by: Adam Carpenter <[email protected]> * Update Arcana Auth SDK version (#1860) * Feat: Add native Base chain support and to all quickstarts (#1859) * Add Base chain to all quickstarts * Bump core package in demo * Release 2.24.7 (develop) (#1863) * update arcana/demo packages and root version * add ts-ignore for arcana * update core, react, vue versions --------- Co-authored-by: Adam Carpenter <[email protected]> * Bump WC deps to the latest (#1866) * Update docs for Base main (#1868) --------- Co-authored-by: mmjee <[email protected]> Co-authored-by: Kat Leight <[email protected]>
Description
Added a package to support the Arcana Auth SDK. See the included documentation for more information.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)Added documentation for the new package.
If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected) – Not relevant
Tests with demo app (SDK)